search

ConsenSysMesh / py-eip712-structs

EIP712 data structure management for python
MIT License
34 stars 26 forks source link

Fixes bug #16 #17

Open josh-davis-vicinft opened 1 year ago

josh-davis-vicinft commented 1 year ago

py-eip712-structs can handle structs that contain other structs and structs that contain arrays of primitives, but it breaks on structs that contain arrays of other structs.

This pull request fixes this.

shane-t commented 1 year ago

@josh-davis-vicinft Thank you for your contribution! This bug often causes people to fork and modify the library. Unfortunately I don't have the ability to disable the pipeline (the original author has left, and it still seems to be linked to an old Travis account) and won't for a while as I'm on leave myself.

So it might be a few weeks before we can merge this and set up a new publication pipeline. Sorry for the delay!

lukaskiss222 commented 1 year ago

When will you merge it?

flipdazed commented 1 year ago

still not merged ....?

BoboTiG commented 7 months ago

If you are still motivated, you could backport the fix to https://github.com/BoboTiG/py-eip712-structs-ng and I would be happy to cut a new release. If you do so, please add a test 🙏🏻

BoboTiG commented 7 months ago

Thanks @josh-davis-vicinft I backported part of that PR to https://github.com/BoboTiG/py-eip712-structs-ng/commit/1c85ea21cf912de46f91a1d96f7a0382b48d1b19 in order to fix #16.

I'll cut a new release for that specific fix, and it someone can share a reproduction code for "...but it breaks on structs that contain arrays of other structs", I'll be happy to work on a second fix.