search

ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

add prop types to most components #323

Closed gesquinca closed 5 years ago

netlify[bot] commented 5 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit ac0785878ca5f6fb35b9b22035c86eb34426c725

https://deploy-preview-323--rimble-ui-storybook.netlify.com

netlify[bot] commented 5 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit 175f6d61c267d4a047d32b33f29934412db7c883

https://deploy-preview-323--rimble-ui-storybook.netlify.com

gesquinca commented 5 years ago

@MikeLockz this adds propTypes without coupling it with the functional component changes so we don't have to remove propTypes because fo the issue with functional components.

gesquinca commented 5 years ago

@MikeLockz Also added a new 'ready to merge' label we can start using. So if all checks pass and the branch is marked 'ready to merge' by the assignee that should mean it's safe to merge? Thoughts?

netlify[bot] commented 5 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit 0dc4350daa66e3bae1fc8104d06e20f89a5b2a85

https://deploy-preview-323--rimble-ui-storybook.netlify.com