ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

Single-Side Borders Not Working #362

Closed MikeLockz closed 4 years ago

MikeLockz commented 4 years ago

Describe the bug Single side border properties do not display a border according to the rimble docs which state that all border properties from styled-system are supported.

image

The spec from styled-system supports styling a single side to any component.

image

https://github.com/styled-system/styled-system/blob/master/docs/table.md#border

To Reproduce Steps to reproduce the behavior:

  1. Create Box component
  2. Add borderRight... props
  3. No borders visible

Expected behavior Should show right side border only.

Screenshots https://codesandbox.io/embed/border-right-bug-038i1

Rimble UI Version

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

gesquinca commented 4 years ago

My guess is that these properties are part of styled system 5. This library uses styled-system 4. Can you verify @MikeLockz ?

See #301

MikeLockz commented 4 years ago

@gesquinca Ya those props are for 5x. Opened a new ticket on the storefront to update the link in the docs to point to the props tables for 4.x version.

Will be resolved by https://github.com/ConsenSys/rimble-storefront/issues/56