search

ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

Added default fontSize to Heading #389

Closed MikeLockz closed 4 years ago

MikeLockz commented 4 years ago

Fixed bug where fontSize wasn't overriding default value.

netlify[bot] commented 4 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit ba87543d28c825461cddbba47872f0b171ef7d67

https://deploy-preview-389--rimble-ui-storybook.netlify.com

netlify[bot] commented 4 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit 2b4b0c1dd1f362eebfd40dd1d1e2f3ad0fb973c4

https://deploy-preview-389--rimble-ui-storybook.netlify.com

netlify[bot] commented 4 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit 76b8ef87cd4897e072b193da99a3d7d082cfe2cd

https://deploy-preview-389--rimble-ui-storybook.netlify.com

MikeLockz commented 4 years ago

@gesquinca this has been waiting for your review. Any feedback?

gesquinca commented 4 years ago

I'm not really loving this particular solution. I'm exploring how other systems are handling this and why at the moment.

MikeLockz commented 4 years ago

Fixed in #421