ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

Node_modules not updating when altering code #390

Open RhinocerosBomb opened 4 years ago

RhinocerosBomb commented 4 years ago

Describe the bug I'd like to help out with some of the bugs but i'm having a hard time getting the demo to update when changes to rimble_ui is made.

To Reproduce Steps to reproduce the behavior:

  1. yarn install in the root, and yarn install in the demo directory.
  2. Make changes to library. For example: changing /src/ToastMessage/index.js
  3. yarn start in the demo directory

Expected behavior node_modules in the demo directory does not update to reflect the changes made

Rimble UI Version

Desktop (please complete the following information):

Additional context I have tried doing yarn install, yarn install --no-lockfile, and yarn update to get it to change but node_modules never updates

MikeLockz commented 4 years ago

Hi @RhinocerosBomb - thanks for taking a look and wanting to help with bugs!

You can get the library to re-compile on change by running yarn start from the root rimble-ui directory. This will watch the /src directory for changes and recompile the library that is used in the demo app. So you will need 2 terminals, both running yarn start - one for the library and one for the react app.

We need to update our instructions for how to work on the codebase. I think that should be the outcome to close this issue.