ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

Revisit Tooltips (spike) #400

Open MikeLockz opened 4 years ago

MikeLockz commented 4 years ago

Goal is to reconsider the arcitecture of the tooltip for 1.0. Wrapping an element and adding a ref, then adding a relatively positioned tooltip to that.

Another option is to move to the coordinates of an element. May be more robust with less issues.

Do we want to switch out the underlying library that we use for the tooltip?

What are the pros/cons of the 2 approaches. Is option 2 better? How much would it take to implement? Also we want our solution to fix the currently open bugs (#393, #380, #369)

Acceptance criteria:

E: 2D

MikeLockz commented 4 years ago

Look at https://github.com/popperjs/react-popper