search

ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

Decrease theme colors #403

Open MikeLockz opened 4 years ago

MikeLockz commented 4 years ago

Audit the theme colors and find ones that can be removed.

Also, consider adding variants for action colors that do not rely on opacity but instead change the hue via a color transform function like lighten (success-light).

Acceptance criteria:

E: 1/2D

MikeLockz commented 4 years ago

This should also get reflected in the Figma kit.

MikeLockz commented 4 years ago

@gesquinca - does it make sense to rename to abstract additional color names to something less tied to color and more tied to function? When I want to override the color of the button text, instead of using text I have to set white: "black" which feels weird. Should there be a new theme.colors.buttonText value?

gesquinca commented 4 years ago

@MikeLockz yes it does. That's why we added these values to the theme recently.

https://github.com/ConsenSys/rimble-ui/blob/master/src/theme.js#L7-L8

This doesn't apply to button colors, but it applies to text color in the page as a whole.