search

ConsenSysMesh / rimble-ui

React components that implement Rimble's Design System.
https://rimble.consensys.design/
MIT License
462 stars 67 forks source link

migrate to styled system 5 #438

Closed gesquinca closed 4 years ago

gesquinca commented 4 years ago

https://styled-system.com/guides/migrating/#migrating-to-v5

netlify[bot] commented 4 years ago

Deploy preview for rimble-ui-storybook ready!

Built with commit e2b308c900219d72a49fddd6855592563bb0ddc6

https://deploy-preview-438--rimble-ui-storybook.netlify.com

MikeLockz commented 4 years ago

@gesquinca the build is failing because of no font-family. Does the test need to get removed to check for a font family now?

MikeLockz commented 4 years ago

@gesquinca I'm not sure where it is coming from, but Heading has a margin: 0 that is getting applied and wiping out the existing top/bottom margins that already exist.

MikeLockz commented 4 years ago

@gesquinca It looks like the font family for Labels isn't getting set.

MikeLockz commented 4 years ago

@gesquinca - Looks like inputs don't have their original drop shadows anymore - is that intentional?

MikeLockz commented 4 years ago

@gesquinca Also for Heading any m props that get added to the component aren't getting honored because there is a margin: 0 that is getting applied last. Not sure where it's coming from.

gesquinca commented 4 years ago

@gesquinca the build is failing because of no font-family. Does the test need to get removed to check for a font family now?

@gesquinca It looks like the font family for Labels isn't getting set.

Yes, font-family needs to get applied to a common parent and cascade down. Not the individual components.

gesquinca commented 4 years ago

@gesquinca I'm not sure where it is coming from, but Heading has a margin: 0 that is getting applied and wiping out the existing top/bottom margins that already exist.

I think I fixed this now.

gesquinca commented 4 years ago

@gesquinca Also for Heading any m props that get added to the component aren't getting honored because there is a margin: 0 that is getting applied last. Not sure where it's coming from.

I think this is resolved now, but we should look at it together.