should tokenCount 0 return true, false, or throw? - Githubissues

ConsenSysMesh / singulardtv-contracts

19 stars 16 forks source link

should tokenCount 0 return true, false, or throw? #33

Open ethers opened 8 years ago

ethers commented 8 years ago

Currently the behavior for all the following is to execute code and return true:

https://github.com/ConsenSys/singulardtv-contracts/blob/66f00bfa775aab9b9852c35e0406037fca42495e/contracts/SingularDTVCrowdfunding.sol#L142

https://github.com/ConsenSys/singulardtv-contracts/blob/66f00bfa775aab9b9852c35e0406037fca42495e/contracts/SingularDTVToken.sol#L89

https://github.com/ConsenSys/singulardtv-contracts/blob/66f00bfa775aab9b9852c35e0406037fca42495e/contracts/SingularDTVToken.sol#L80

It seems fine and leads to less source code; I'll look if this goes against any recommended security principles.