search

ConsenSysMesh / solidity-parser

Solidity Parser in Javascript
138 stars 54 forks source link

Update PEG.js dependency #24

Closed federicobond closed 7 years ago

tcoulter commented 7 years ago

Do we know if this upgrade affects the output or structure of the AST? We don't have great tests for that, admittedly.

tcoulter commented 7 years ago

Very happy to have this upgrade, and thank you @federicobond. Want to double check the above before merging.

federicobond commented 7 years ago

I checked the full changelog for the latest release of PEG.js, and found no user-visible changes.

I can diff the output against my whole spec if you want though. El El mié, 23 de nov. de 2016 a las 18:05, Tim Coulter < notifications@github.com> escribió:

Very happy to have this upgrade, and thank you @federicobond https://github.com/federicobond. Want to double check the above before merging.

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/ConsenSys/solidity-parser/pull/24#issuecomment-262629719, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIcuiZ4CI7BhOJwkWHhj_mnF5Zt3jAZks5rBKqIgaJpZM4KxCjW .

tcoulter commented 7 years ago

Nope, sounds good. Thanks @federicobond!