search

ConsenSysMesh / solidity-parser

Solidity Parser in Javascript
138 stars 54 forks source link

Merge in changes from duaraghav8/solparse #6

Closed axic closed 8 years ago

axic commented 8 years ago

Would it be possible to have a single project for AST parsing?

cc @tcoulter @duaraghav8

duaraghav8 commented 8 years ago

@axic I guess this repo is not being actively maintained (which is the reason I created solparse). However, I'd be happy to merge if ConsenSys team is interested.

tcoulter commented 8 years ago

This project is being maintained so long as features are needed, and it's used actively in Truffle 2.0.

@axic Which project should this go into (or should merge with this)?

tcoulter commented 8 years ago

Ah, I didn't read the title. I'll check it out

tcoulter commented 8 years ago

@duaraghav8 I'd be happy to merge those changes. Somehow I missed your PR, which you submitted two weeks ago. I'll add the merge of your whole fork into my list of current tasks. I appreciate your help. Thanks @axic for bringing this to my attention. @duaraghav8, apologies for not seeing your initial PR.

duaraghav8 commented 8 years ago

@tcoulter That's great! The only changes made are in solidity.pegjs and build/parser.js. I created my fork primarily so I could quickly push code and make releases, since 4 of my projects are now (heavily) dependant on solidity parser.

Please let me know if you require anything from my side.

tcoulter commented 8 years ago

Sorry for the lateness on this. Your fork has been merged into the master branch. I added some code to the parsing examples to cover the bugs that you fixed. I didn't keep the rename of solidity-parser.pegjs, however (mostly a stylistic preference, though open to the rename if there's a better reason).

Just to better communicate the situation: I maintain Truffle, ethereumjs-testrpc, solidity-parser and EtherPudding (among other things) as a one-man team. Though it may take me a bit to get to PR's, I'm very happy to receive them and I very much love the participation. In the future, definitely submit more PRs for all your fixes (I know you tried with one, but it took me awhile to get to). I really appreciate it.

Thanks again!

tcoulter commented 8 years ago

@duaraghav8 FYI: solidity-parser 0.1.0 released. Also, I kept you in the list of authors in package.json. Thanks again.

duaraghav8 commented 8 years ago

Awesome! Nope, keeping the same name is fine.

Sure, I will be submitting issues & PRs soon, since a couple of people have raised solidity-parser related issues on my repos (my projects rely on this module).

Thanks! =)

tcoulter commented 8 years ago

👏