search

ConsenSysMesh / solidity-parser

Solidity Parser in Javascript
137 stars 53 forks source link

Also build parser on postinstall? #77

Closed cgewecke closed 6 years ago

cgewecke commented 7 years ago

@frangio added this nice build script in #64 - initially he used the prepare hook but because that's so new it was changed to prepublish.

This works well for CI and publishing to npm but if you try to install SP as a dependency from the git repo in order to have access to the latest changes, the built parser isn't there. This issue at npm describes the problem.

It looks like having a postinstall hook would make it possible to install successfully from the repo, Does anyone have any views about this?

elenadimitrova commented 7 years ago

In fact it doesn't work well in CI when using yarn, see https://github.com/ConsenSys/solidity-parser/pull/64#issuecomment-311887116

cgewecke commented 7 years ago

Thanks @elenadimitrova! Good to know.