Closed barlock closed 5 years ago
Okay, cool. Does noon tomorrow work?
On Thu, Mar 21, 2019 at 9:39 AM Michael Barlock notifications@github.com wrote:
Related Issue Supports #96 https://github.com/ConsenSys/web3studio-bootleg/issues/96
Related PRs This PR is not dependent on any other PR
What does this PR do? Fixes the deploys and adds a test case for the error.
Description of Changes Deploys are failing as there isn't a clean git tree https://travis-ci.com/ConsenSys/web3studio-bootleg/jobs/186665523#L896
This is caused by yarn being run and updating the yarn.lock. Test case checks pre-merge that this isn't the case so that deploys will flow through.
What gif most accurately describes how I feel towards this PR? [image: treebeard] https://camo.githubusercontent.com/d81035fca8e1534e53e2a74a8653beb2a3b49387/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f714f34755a38336b59384b71592f67697068792e676966
You can view, comment on, or merge this pull request online at:
https://github.com/ConsenSys/web3studio-bootleg/pull/155 Commit Summary
- Test for clean git tree in test so travis can deploy
File Changes
- M package.json https://github.com/ConsenSys/web3studio-bootleg/pull/155/files#diff-0 (2)
- A packages/bootleg-common/bin/bootleg-clean-tree https://github.com/ConsenSys/web3studio-bootleg/pull/155/files#diff-1 (6)
- M packages/bootleg-common/package.json https://github.com/ConsenSys/web3studio-bootleg/pull/155/files#diff-2 (5)
- M yarn.lock https://github.com/ConsenSys/web3studio-bootleg/pull/155/files#diff-3 (2176)
Patch Links:
- https://github.com/ConsenSys/web3studio-bootleg/pull/155.patch
- https://github.com/ConsenSys/web3studio-bootleg/pull/155.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ConsenSys/web3studio-bootleg/pull/155, or mute the thread https://github.com/notifications/unsubscribe-auth/AotM1LMF_JsAfBC1XRjVNFvg40CiMGobks5vY4uCgaJpZM4cBc4h .
Related Issue
Supports #96
Related PRs
This PR is not dependent on any other PR
What does this PR do?
Fixes the deploys and adds a test case for the error.
Description of Changes
Deploys are failing as there isn't a clean git tree https://travis-ci.com/ConsenSys/web3studio-bootleg/jobs/186665523#L896
This is caused by
yarn
being run and updating the yarn.lock. Test case checks pre-merge that this isn't the case so that deploys will flow through.What gif most accurately describes how I feel towards this PR?
![treebeard](https://media2.giphy.com/media/qO4uZ83kY8KqY/giphy.gif)