search

Consensys / EthOn

EthOn - The Ethereum Ontology
http://ethon.consensys.net
Other
245 stars 44 forks source link

removed functionality of txReciepts #89

Closed sunnya97 closed 7 years ago

sunnya97 commented 7 years ago

Addresses #75

jo-tud commented 7 years ago

I love this - however, it moves EthOn a big step away from the protocol specification. Therefore, please merge into dev ( @webthethird ).

@webthethird Please make sure the illustrations reflect this major change.

Here's the full rationale for the record: Transaction Receipts are used by Ethereum nodes to persist information that can only be known after processing a transaction. In EthOn we just attach this additional information to the Tx itself, once it is known. There is no need to make the model more complex by adding Receipts because EthOn is not a specification for client implementation (unlike the YP).

webthethird commented 7 years ago

@jo-tud My apologies, I merged into master instead of the dev branch. Should I revert this and continue on the dev branch?

webthethird commented 7 years ago

@jo-tud The main illustration didn't include TxReceipts originally, so there is nothing to remove there. I am going to go over the other illustrations and update them according to the new changes.

jo-tud commented 7 years ago

Yes, please revert and then merge into dev.