Closed sunnya97 closed 7 years ago
Points 1, 2 and 4 seem like straightforward fixes
Would be good to get feedback from @jo-tud on the third point
Does the account code hash ever change once it has been uploaded to the EVM?
No, account code hash will never change.
@sunnya97 Then can you explain your reasoning for moving 'accountCodeHashto be a property of
Account Staterather than
Contract Account`? I see in the current definition of Account State that
It is comprised on four pieces of information: nonce, balance, storage root and code hash
which would seem to justify the change. But intuitively the term Account State implies change to me, since nonce, balance and storage all have changing states. Does that make sense?
Would be interested in hearing what @chronaeon thinks
@webthethird The definition of AccountState really does differ from the ontological model atm. I changed it.
Excellent, thanks for taking care of that. Makes sense to me!