search

Consensys / Token-Factory

Basic Token Factory dapp.
479 stars 308 forks source link

Uport integration #27

Closed coder5876 closed 8 years ago

coder5876 commented 8 years ago

Added uPort integration. Also changed a synchronous call web3.eth.accounts to async web3.eth.getAccounts().

coder5876 commented 8 years ago

Would be nice if you could ignore whitespace changes in the diff. Right now it looks like the whole file token page.jsx got changed while in reality it's just a couple lines.

simondlr commented 8 years ago

I'm musing on this...

Since uPort isn't out yet, I want users to download Metamask if it has not been injected yet (give them a notification).

So putting this on ice for now until uPort is fully out? Unless we spend time to make a choice modal?

ie, if site starts & there's no web3. Tell user: -> You need to install Metamask or use Mist. -> Or use uPort.

Choose -> refresh. Save choice in localstorage. Then have a settings cog built into the nav bar, to swap out method of interaction.

simondlr commented 8 years ago

Thanks for this @christianlundkvist. Went with a slightly different, but incorporated your code.