search

Consensys / Tokens

Ethereum Token Contracts
MIT License
2.06k stars 1.2k forks source link

Add linting #100

Closed maurelian closed 6 years ago

maurelian commented 6 years ago

Solhint and airbnb style

maurelian commented 6 years ago

get some nifty badges

maurelian commented 6 years ago

Be like Nick:

image

gitcoinbot commented 6 years ago

This issue now has a funding of 0.055 ETH (36.12 USD) attached to it.

romanjesus commented 6 years ago

I tried claiming this and submitted the form on gitcoin. Any preferences on the linter?

nemani commented 6 years ago

Hey, I am a contributor to coala. Check it out if it can help you in linting. :)

gitcoinbot commented 6 years ago

The funding of 0.055 ETH (37.22 USD) attached has been claimed by @elaniobro.

@elaniobro, please leave a comment to let the funder (@owocki) and the other parties involved your implementation plan. If you don't leave a comment, the funder may expire your claim at their discretion.

Elaniobro commented 6 years ago

@maurelian, I claimed this off gitcoin.co but I see @romanjesus note above. Lets sort this out before any work is done shall we?

owocki commented 6 years ago

hey @romanjesus -- i'm trying to let the gitcoin.co web3 instance be the source of truth for who owns the issue. sorry for the miscommunication but i think that the claim should go to @Elaniobro , this is something were actively trying to address via https://github.com/gitcoinco/web/pull/62

romanjesus commented 6 years ago

No worries at all. That's fine, I didn't have metamask set up. Thanks!

Sent from my Pixel

On Dec 14, 2017 4:36 PM, "Kevin Owocki" notifications@github.com wrote:

hey @romanjesus https://github.com/romanjesus -- i'm trying to let the gitcoin.co web3 instance be the source of truth for who owns the issue. sorry for the miscommunication but i think that the claim should go to @Elaniobro https://github.com/elaniobro , this is something were actively trying to address via gitcoinco/web#62 https://github.com/gitcoinco/web/pull/62

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ConsenSys/Tokens/issues/100#issuecomment-351857310, or mute the thread https://github.com/notifications/unsubscribe-auth/ASmEMjR-_mB7Zk4i-u5ZoCyhRGn9Lngxks5tAaLTgaJpZM4RAxGV .

owocki commented 6 years ago

@romanjesus thanks for understanding. heres a comment for figuring out metamask if you still want to give it a shot https://github.com/gitcoinco/gitcoinco/issues/4

Elaniobro commented 6 years ago

@maurelian can you provide some more info about what type of linting you want?

Thanks!

Edit: I see, you want sol linting 👍

Elaniobro commented 6 years ago

@maurelian Wanted to give you an update, I submitted a PullRequest #104 this is working for me locally. As noted in the PR To Do still few more tweaks and we will be all set.

Elaniobro commented 6 years ago

@maurelian I resolved the TODO's. Cheers!

gitcoinbot commented 6 years ago

The funding of 0.055 ETH (43.67 USD) attached to this issue has been approved & issued to @elaniobro.