search

Consensys / Tokens

Ethereum Token Contracts
MIT License
2.06k stars 1.2k forks source link

Add Solhint and eslint linters #106

Closed maurelian closed 6 years ago

maurelian commented 6 years ago

Description: This adds configuration of linters for both javascript and solidity. It also makes changes to ensure the code conforms to the new linter configurations.

The AirBnB js styleguide is used without modification, but in a few locations rules are disabled via comments.

A scripts.posttest field was added to the package.json file to lint after tests are run.

skmgoldin commented 6 years ago

I've rebased this branch. Do you mind if I force push? Your commits are preserved.

maurelian commented 6 years ago

@skmgoldin no problem, please go ahead.

skmgoldin commented 6 years ago

I am going to do a line by line review of this, but two things up front:

  1. This is great, thanks for doing it.
  2. The EIP20Factory test, which previously ran very slowly, now runs quickly. Looking at the diff, I can't figure out why. Any ideas?
maurelian commented 6 years ago

No idea why that factory test is so fast now.