Update truffle and tests to error on Revert

Consensys / Tokens

Ethereum Token Contracts

MIT License

2.06k stars 1.19k forks source link

Closed maurelian closed 6 years ago

maurelian commented 6 years ago

I upgraded truffle to 4.0.6 to get the proper revert message.

This is a pre-req for integrating solidity-coverage.

skmgoldin commented 6 years ago

Also, I know you hate staging, but would you mind making this PR to staging?

maurelian commented 6 years ago

@skmgoldin FYI, I've learned to stop worrying and love the staging.

Other changes:

fixed conflicts with staging
improved linting scripts, which were missing some files (FYI, eslint --debug is a good way to check which files get linted)
implemented assertRevert just the way you like it.

skmgoldin commented 6 years ago

LFGTM