Consensys / UniversalToken

Implementation of Universal Token for Assets and Payments
Apache License 2.0
347 stars 188 forks source link

Hold Trade support for DVP #120

Closed ecp4224 closed 2 years ago

ecp4224 commented 2 years ago

Description

Motivation and Context

This MR adds the Hold Trade Type to the DVP contract and adds support for different trade types for both the sender and receiver. Allowing different trade types allows for more combination of trade possibilities between a sender and receiver. This MR also introduces some quality of life changes as well as some API changes to support holds/different trade types

How Has This Been Tested?

Unit tests have been adjusted to support the API changes with the new DVP contract

Screenshots (if appropriate):

Types of changes

Checklist:

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️