Consensys / UniversalToken

Implementation of Universal Token for Assets and Payments
Apache License 2.0
347 stars 188 forks source link

Remove DomainAware from ERC20Token and ERC721Token #123

Closed ecp4224 closed 2 years ago

ecp4224 commented 2 years ago

Description

Removes the DomainAware contract from ERC20Token and ERC721Token

Motivation and Context

Currently, the DomainAware uses the chainId opcode to determine what chain the current Contract is running on. However, some internal tools do not support this opcode (yet), and since these tokens aren't ever doing any signing verification (unlike ERC1400Token) it is safe to remove for now to get internal tools working.

Once internal tools have been updated to support the chainId opcode, this should be added back to these contracts

How Has This Been Tested?

All unit tests are passing, currently nothing was using the DomainAware contract for ERC20Token and ERC721Token

Types of changes

Checklist:

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️