search

Consensys / UniversalToken

Implementation of Universal Token for Assets and Payments
Apache License 2.0
347 stars 188 forks source link

How data conservation is handled during the migrations ? #56

Closed ArvsIndrarys closed 4 years ago

ArvsIndrarys commented 4 years ago

The ERC1400 seems to hold all the data of the implementation. Its migration code seems to only update the reference in the ERC1820 contract.

I wonder how data migration is handled? Is it not? Or is there a mecanism to access the data of the base contract from the new one ? And why not have a storage contract to handle this?

gauthierpetetin commented 4 years ago

Hello @ArvsIndrarys, Thanks for you question. Indeed the migration code only updates the reference in the ERC1820 contract. There's no mechanism to access the data of the base contract from the new one (tokens need to be re-minted in that case), which encourages to place the "upgradeable code" in a token extension contract, while the core ERC1400 code shall remain the same. Having a storage contract would be interesting as well but is not done in this implementation.

ArvsIndrarys commented 4 years ago

Hello @gauthierpetetin ! Thanks for answering, you can close the issue :)