search

Consensys / abi-decoder

Nodejs and Javascript library for decoding data params and events from ethereum transactions
GNU General Public License v3.0
640 stars 223 forks source link

Wrong Decoding of Transaction Receipt Logs #44

Closed RashikaAggarwal closed 4 years ago

RashikaAggarwal commented 5 years ago

Hi, I am using abiDecoder.decodeLogs(receipt.logs) to decode the logs of my quorum transactions. It decodes the addresses incorrectly in the logs. For example- My actual account address is - 0x955B26E07213e7724C936b2e6765Ab0BC15bdb17 but the decoded the output address comes - 0x955b26e07213e7724c936b2e6765ab0bc15bdb17

Similary, another account address is - 0x1932c48b2bf8102ba33b4a6b545c32236e342f34 but the decoded output address comes - 0x1932c48b2bF8102Ba33B4A6B545C32236e342f34

I am using abi-decoder version - 2.2.1 with web3 version - 1.2.1. Please explain the reason behind this irregular behaviour. This wrong decoding occurs in just addresses but rest of the decoded logs output comes correct.

efiShtain commented 5 years ago

Ethereum addresses are case insensitive, this are the same addresses

RashikaAggarwal commented 5 years ago

I agree these are the same addresses but earlier when i was using older versions of web3 and abi-decoder, this scenario never happened. Therefore, i wanted to know is there any reason behind this slight change in characters?

denisgranha commented 4 years ago

in the v2 versions of the decoder web3 v1 was added, and it uses checksum addresses