search

Consensys / armlet

a MythX API client wrapper
MIT License
17 stars 7 forks source link

Handle HTTP(S) redirects? #17

Closed rocky closed 5 years ago

rocky commented 5 years ago

Should armlet handle these? For example: 

 ./analysis 
Error: Invalid status code 308, <html>
<head><title>308 Permanent Redirect</title></head>
<body>
<center><h1>308 Permanent Redirect</h1></center>
<hr><center>nginx/1.15.5</center>
</body>
</html>
birdofpreyru commented 5 years ago

It happens only if http:// scheme is used instead of https://. For me it seems fine to crush, so that user figures out that he should use https:// instead, and not to cause any redirects.

rocky commented 5 years ago

This is the situation now, but is that always going to be the case?

rocky commented 5 years ago

This was addressed along with URL canonicalization in https://github.com/ConsenSys/armlet/pull/53 .