Closed daniyarchambylov closed 5 years ago
@fgimenez you said that we already can create object with const client = new armlet.Client()
but I don't see changes that would allow it https://github.com/ConsenSys/armlet/blob/master/index.js#L14
If you have those changes which branch is it? Or I can do it myself :)
@daniyarchambylov @fgimenez let's hold off on merging this until after release 1.0.0. It doesn't look like a bug fix but an improvement. And it will be coordinated with other improvements that we will need in truffle-analyze.
changed base branch for PR. It shouldn't affect master branch @rocky @fgimenez
@fgimenez I see your point. If we'll use userIid for trial user authentication then there is no need to pass userId. I'll fix PR
Totals | |
---|---|
Change from base Build 168: | 0.07% |
Covered Lines: | 193 |
Relevant Lines: | 194 |
@fgimenez I didn't add trial user authentication here yet. It will be done in separate PR. For now login with userId is treated same way ethAddress is. When trial userId will be provided I will also add changes to accept empty password and Client instantiation with no params.