Consensys / armlet

a MythX API client wrapper
MIT License
17 stars 7 forks source link

Better error messages and recovery #43

Closed rocky closed 5 years ago

rocky commented 5 years ago

If MythX fails, it can return the empty string rather than valid data - perhaps this is a Maestro bug? For now, we catch the string and turn it into and empty object.

Give a better error message on a timeout. And we don't want tracebacks either here.

Start release notes.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 206


Changes Missing Coverage Covered Lines Changed/Added Lines %
index.js 6 8 75.0%
<!-- Total: 13 15 86.67% -->
Totals Coverage Status
Change from base Build 202: -1.3%
Covered Lines: 222
Relevant Lines: 230

💛 - Coveralls
rocky commented 5 years ago

Due to lack of time for getting a release out, the coveralls slippage I need to live with for now. @daniyarchambylov go back and see if you can get this fixed. It has to do with testing the custom error message that occurs when the ethereum address is invalid. I did spend a bit of time trying to figure out how to add a test but couldn't figure it out.