coveralls
commented
5 years ago Pull Request Test Coverage Report for Build 248
- 1 of 6 (16.67%) changed or added relevant lines in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-1.5%) to 84.433%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/login.js | 1 | 6 | 16.67% | ||
| <!-- | Total: | 1 | 6 | 16.67% | --> |
| Totals | |
|---|---|
| Change from base Build 242: | -1.5% |
| Covered Lines: | 221 |
| Relevant Lines: | 260 |
@fgimenez mentioned having a problem in the code the last time I suggested converting http:// to https:// because you run locally which allows the http protocol.
Here we only do a http->https redirect only on a HTTP 308 response which in your situation won't occur.
If this is acceptable, let me know. This is a nice to have but not as user-friendly necessary as some of the other HTTP response code handling I feel are.