Consensys / armlet

a MythX API client wrapper

MIT License

17 stars 7 forks source link

Pull Request Test Coverage Report for Build 250

15 of 18 (83.33%) changed or added relevant lines in 5 files are covered.

4 unchanged lines in 2 files lost coverage.

Overall coverage decreased (-1.1%) to 83.29%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
index.js	6	9	66.67%
<!--	Total:	15	18	83.33%	-->

Changes Missing Coverage

Covered Lines

Changed/Added Lines

index.js

66.67%

<!--

Total:

83.33%

-->

Files with Coverage Reduction	New Missed Lines	%
lib/refresh.js	2	90.32%
lib/login.js	2	75.61%
<!--	Total:	4	-->

Files with Coverage Reduction

New Missed Lines

lib/refresh.js

90.32%

lib/login.js

75.61%

<!--

Total:

-->

Totals
Change from base Build 249:	-1.1%
Covered Lines:	227
Relevant Lines:	270

Totals

Change from base Build 249:

-1.1%

Covered Lines:

227

Relevant Lines:

270

SInce we are now doing URL canonicalization as a result of feedback of people making mistakes in URLs I would like you all to consider #50 along with this which I have personally encountered.

50 might not be the the most general as it converts http to https which happens to be relevant in our particular setup. More general would be to get the redirect from the HTTP response.

@daniyarchambylov @fgimenez what do you think? @daniyarchambylov would you be willing to shepard this through? If so, later I will update the JIRA ticket to include this.

Consensys / armlet

add urlJoin function #53

Pull Request Test Coverage Report for Build 250

💛 - Coveralls

50 might not be the the most general as it converts http to https which happens to be relevant in our particular setup. More general would be to get the redirect from the HTTP response.