search

Consensys / armlet

a MythX API client wrapper
MIT License
17 stars 7 forks source link

[Improvemnts]change http-client from http(s) to request for proxy environment in p… #55

Closed tagomaru closed 5 years ago

tagomaru commented 5 years ago

Armlet usually uses request package as http-client. However, somehow http(s) package is used in poller.js This may make users in environment with proxy difficult to use armlet. I changed http-client in poller.js from http(s) to request. Could you check my PR and merge it?

rocky commented 5 years ago

HI Teruhiro -

Thanks in your interest here. I appreciate it.

There is unfortunate timing: your PR come in just at a time when a refactoring of that polling code was in progress. That other PR is needed because our API will be changing a little in the way HTTP responses are handled when there is an error in the analysis.

Please look at what is in master currently, to see if that addresses your concern. And let us know what you think.

If it does address your concern, close the PR.

tagomaru commented 5 years ago

@rocky Thank you for the kind reply and aplogy for the conflict. I close this PR. However, isomorphic-fetch did not address my concern. I sent new PR to address this. See #56

tagomaru commented 5 years ago

See #56