search

Consensys / armlet

a MythX API client wrapper
MIT License
17 stars 7 forks source link

Convert lib/refresh.js to use omni-fetch #90

Open rocky opened 5 years ago

tagomaru commented 5 years ago

@rocky Do you mean reflesh.js should use isomorphic-fetch ? If so, i think we should use omni-fetch instead of isomorphic-fetch as I did before, since isomorphic-fetch never supports proxy. request supports proxy.

rocky commented 5 years ago

Ok, make that omni-fetch then. Don't mind me, I don't know what I'm talking about. I just know that this pair and request are fundamentally different in terms of the kinds of objects they return.

tagomaru commented 5 years ago

Just never use http client package which does not support proxy. Many companies are in proxy enviroment and proxy is useful to developer and penetration tester to use local proxy tool like me.

For example, I could notice many unnecesary login requests thanks to local proxy tool.