Interleaved columns have values which are not in the source columns

[letypequividelespoubelles]

To reproduce : corset java constraints

Test successionOverlappingMstore() in MemoryTests.java, corset inspect module MMIO, columns VAL_ABC and VAL_ABC_NEW have values which are not in the source columns (VAL_A, VAL_B, VAL_C, VAL_A_NEW, VAL_B_NEW, VAL_C_NEW)

[DavePearce]

Connected with #94 ?

[DavePearce]

@letypequividelespoubelles Its not really enough information for me to reproduce this error. Can you include the trace that that you are running corset check with? And, ideally, a bit more info about which row/column in that file is causing the problem.

[letypequividelespoubelles]

Maybe just a display issue of corset inspect, as (presumably) in #112 ?

[DavePearce]

Ok, recreation steps:

1. Checked out head of feat/issue-142/mmio (commit cc64d1d)
2. Rebuild zkevm-constraints/zkevm.bin
3. Within the inspector select mmio module, and goto column 97 (?)

Screenshot attached.

The problematic number is the one starting 2668881309183831085987251822994260480

[DavePearce]

NOTES

• VAL_ABC and VAL_ABC_NEW are computed columns arising from an interleaving constraint.
• Column 48 has 1334440654591915542993625911497130241 for VAL_ABC

[DavePearce]

Ok, so this is starting to look like a presentation error. The offending number does exist in the original trace file. Specifically, we have this equivalence:

2668881309183831085987251822994260480 = 0x202020202020202020202020202020

So, the remaining question is why this is not being displayed in the correct form.

[DavePearce]

Ok, for reasons unknown, the column base is set to Dec for these columns rather than Hex (as for other columns). I guess because they are computed columns?

[DavePearce]

It is possible to override the default base for an interleaved column like so:

(module test)
(defcolumns (A :byte) (B :byte))
(definterleaved (C :display :hex) (A B))

However, I think the default should be Hex anyway.

UPDATE: Yes Hex is the default for a column unless specified otherwise.