search

Consensys / corset

4 stars 10 forks source link

Unused Field `Column::shift` ? #131

Closed DavePearce closed 2 days ago

DavePearce commented 2 weeks ago

I believe the following field defined in column.rs is unused and could be safely removed:

pub struct Column {
    ...
    pub shift: i16,

I don't know what this field is supposed to do, but if it is deleted ... then corset still builds. Therefore, I propose to remove this field altogether.

@delehef Any thoughts on this?

delehef commented 2 weeks ago

Yes, it can be safely removed.