Consensys / doc.linea

Linea documentation
https://docs.linea.build
Apache License 2.0
296 stars 368 forks source link

[DOCS] update card component styling to be consistent regardless of screen size #621

Closed SKorchinskiy closed 1 week ago

SKorchinskiy commented 3 weeks ago

I've opened the main page of the docs on my MacBook Air M1 13.3" and the card component looks inconsistent:

linea-docs-1

As you can see from the screenshot above, the "run a node"-card is shorter than other cards.

To solve this issue, I've added additional styling which is meant to make card component's height the same among components regardless of screen size

Now it looks like this:

linea-docs-2

I've also fixed it for smaller screens. For example, the main page with 1001x1125 screen parameters currently looks like this:

linea-docs-3

However, with the changes I've made, it looks like this:

linea-docs-4
vercel[bot] commented 3 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 4:11pm
SKorchinskiy commented 2 weeks ago

Hi, @jlwllmr. This PR is ready for a review

jlwllmr commented 1 week ago

thanks @SKorchinskiy. Tagging in @sammysango who takes care of the site's design

jlwllmr commented 1 week ago

@SKorchinskiy hey, we merged an improvement along these lines separately in #631 as it's something that was on our roadmap to fix anyway — we used a different approach, but we already had something like the logic we needed from a different repo so opted for that method. Thank you for prompting us on this.