Consensys / eth-lightwallet

Lightweight JS Wallet for Node and the browser
MIT License
1.46k stars 501 forks source link

Bitcore dependencies should be updated #135

Closed roderik closed 7 years ago

roderik commented 7 years ago

The current version locks fail since today. Fixed versions have been relesed by the bitcore team.

The error is:

screen shot 2017-03-15 at 22 19 15

Got the same issue in an other project: https://github.com/bitpay/bitcore-ecies/issues/42

In this case, it's the combination with bitcore-mnemonic, a fix release has been made: https://github.com/bitpay/bitcore-mnemonic/releases

danfinlay commented 7 years ago

Related to #131

coder5876 commented 7 years ago

Thanks roderik, will make sure to update in the upcoming release!

roderik commented 7 years ago

This can be fixed by merging #136

The current package.json installs the new v1.2.2 of mnemonic, and does not use the latest 'lib' version, causing the version mismatch.

jaycarey commented 7 years ago

We've got the same issue here. We can't build our software at the moment because the current release version of eth-lightwallet pulls in 2 versions of bitcore-lib and triggers the guard above.

@roderik Thanks very much for the fix, we're using that for now.

@christianlundkvist Have you considered freezing the versions you release to npm? Using the carat in dependency versions effectively means the software is mutable in ways your can't control once shipped. This causes problems like the above downstream.

coder5876 commented 7 years ago

Hi @roderik, I'll merge in your PR today to do a quick fix for this, thanks!

@jaycarey Yeah, you're right in that I should freeze the versions. If everyone followed Semantic versioning these things would not happen, but that's out of my control as your rightly point out.

jaycarey commented 7 years ago

@christianlundkvist Agreed, proper versioning is the ideal solution. But I guess I have semver trust issues! 😄 Cheers for the awesome library btw.

ajunge commented 7 years ago

Merged version works. I think this issue can be closed

coder5876 commented 7 years ago

This is now fixed after merging the PR https://github.com/ConsenSys/eth-lightwallet/pull/136 by @roderik