search

Consensys / eth-lightwallet

Lightweight JS Wallet for Node and the browser
MIT License
1.46k stars 501 forks source link

bitcore-lib double instance #167

Closed eepstein closed 6 years ago

eepstein commented 6 years ago

eth-lightwallet is directly including 0.14.0 of the library while indirectly including 0.15.0 of it via its dependence on bitcore-mnemonic.

Can't the direct dependence just be removed?

this double dependency causes issues when being used in command-line tools.

achadha235 commented 6 years ago

I think having peerDependencies set for a minimum version of bitcore-lib in bitcore-mnemonic could solve this ¯_(ツ)_/¯

Edit: https://github.com/bitpay/bitcore-mnemonic/pull/26 I think heres a relevant PR.

coder5876 commented 6 years ago

Please see this issue https://github.com/ConsenSys/eth-lightwallet/issues/164 for a fix.