search

Consensys / eth-lightwallet

Lightweight JS Wallet for Node and the browser
MIT License
1.46k stars 501 forks source link

https://github.com/ConsenSys/eth-lightwallet/issues/182: createVault … #193

Open abhiramhatolkar opened 6 years ago

abhiramhatolkar commented 6 years ago

At present if init function throws error if invalid mnemonic occurs which is not caught by createVault function. This results in end users unable to handle that error. Wrapping the call to init function with try catch and passing err to callback if error comes will allow users to gracefully handle the situation.

DalderupMaurice commented 6 years ago

What's the status of this PR? It would be nice to see this merged in