Consensys / eth-lightwallet

Lightweight JS Wallet for Node and the browser
MIT License
1.46k stars 501 forks source link

Example/webwallet #204

Open lerennardleonard opened 6 years ago

lerennardleonard commented 6 years ago

Hi, first thank you for the awesome work ! I'm working with your lightwallet in order to make an atomic swap ready light wallet. Trough my research I've found some issues in this file https://github.com/ConsenSys/eth-lightwallet/blob/master/example/webwallet.html

I think there is an html error on the example/webwallet.html The problem is that at line 165 and 175, both inputs have the same id (id="sendValueAmount") Therefore, there is a conflict between both inputs resulting in any transaction towards a contract having a value of 0. Moreover, there is an other problem with arguments passing towards the contract. They are JSON parsed but they shouldn't. The call to a contract's function expects a javascript array. I'll be glad to help by making a pull request of an updated file.