search

Consensys / eth-lightwallet

Lightweight JS Wallet for Node and the browser
MIT License
1.46k stars 501 forks source link

Is this library a dead-end? Or will it be updated to work with web3.js 1.0? #206

Open Muhammad-Altabba opened 6 years ago

Muhammad-Altabba commented 6 years ago

No updates for this repository since early 2018. And too many issues opened in addition to Pull Requests since 2016. Is this a dead-end? If not, when will it be updated to work with Web3.js version 1.0? Thanks,

Muhammad-Altabba commented 6 years ago

Hello @pelle, @atoulme, @roderik, @mroth and @tcoulter, Your input is valuable. Many thanks,

atoulme commented 6 years ago

Hi @Muhammad-Altabba, thank you for your inquiry. How much work do you think moving to web3.js 1.0 will consist of? Would you like to place a bounty on this task, or provide a patch?

Muhammad-Altabba commented 6 years ago

Hi @atoulme , Thanks for your response. Actually, I am not sure about that. Could you help by providing in brief, or preferably in details, the places where do you think the modifications are needed? So, based on that, I can do some research regarding... Many Thanks,

atoulme commented 6 years ago

I downloaded the code and performed the upgrade. With a few changes - that were helpfully already commented - I made all tests pass locally with the latest web3 build. I have pushed the commit to a branch of mine: https://github.com/atoulme/eth-lightwallet/commit/64c13f4e1a5ae7688e9d2a173842c355512ad70e

Now starts your part. Please review the changes, make sure everything works OK, open a PR with them and make sure it lands on master on this repo.

Muhammad-Altabba commented 5 years ago

Hello @atoulme, It is working well. I made the pull request: https://github.com/ConsenSys/eth-lightwallet/pull/212. Sorry that I was extremely busy finalizing some other things.

Muhammad-Altabba commented 5 years ago

Hi @atoulme, Do you like to accept the pull request https://github.com/ConsenSys/eth-lightwallet/pull/212 and close this issue?