search

Consensys / eth-lightwallet

Lightweight JS Wallet for Node and the browser
MIT License
1.47k stars 503 forks source link

Why was the bitcore-lib removed in 3.0.0 and added again in 3.0.1? #214

Closed marcoskubis closed 5 years ago

marcoskubis commented 5 years ago

In the release notes of the version 3.0.0, the bitcore-lib was removed (last line): image

Why bitcore-lib was removed in 3.0.0 and added again in 3.0.1? This commit It is conflicting with bitcore-mnemonic, that also requires bitcore-lib:

image (electron app)

dividezero commented 5 years ago

From my investigations, the key cause is in the new 1.7.0 version of bitcore-mnemonic.

screenshot 2018-12-04 at 3 44 39 pm

Specifically this commit https://github.com/bitpay/bitcore-mnemonic/commit/3ddf49e247ed1c396976eddf67f8c5c103aa3554

If we change lightwallet's bitcore-mnemonic dependency for it to retain 1.5.0 (by just removing the caret in package.json) it wouldn't be an issue

ameensol commented 5 years ago

I just ran into this error as well.

theomarshanti commented 5 years ago

PR that solves it is here: https://github.com/ConsenSys/eth-lightwallet/pull/215

sameepsi commented 5 years ago

Any updates on this PR?

sameepsi commented 5 years ago

Looks like this project is no longer updated

miladmostavi commented 5 years ago

This was resolved in 4.0.0.