Closed mul1sh closed 5 years ago
@raulk nothing yet, this is just an initial commit. I've been asking on the issue thread ,for several days now, whether I should go ahead and implement the full lerna module separation, but i got no answer.
Nonetheless let me ask the same question here, should I go ahead and do the separation or wait for issue #106 to be solved as indicated? This is the only thing holding me otherwise I would have finished by now 🙂
Hey, thanks for the clarification. I realised that using lerna introduces a package-lock.json
. We are using yarn instead of npm. Any way to integrate lerna with yarn, or should we use yarn workspaces instead?
BTW - even if #106 is not ready yet, you could start configuring the build for the core
and erc20
modules.
@raulk thanks for the feedback, i'll get started then. As for the yarn integration, yes we'll use workspaces, in fact lerna
already supports this integration by passing the flag --use-workspaces
when bootstrapping a new lerna project.
@mul1sh any progress here?
@raulk yes, pushing in abit
Closing this PR as there has been no progress and the feedback has not been addressed yet. @mul1sh, let's continue discussing how to move forward in the bounty issue #107.
This is a WIP PR to fix the issue #107 thanks 🙂