search

Consensys / ethql

A GraphQL interface to Ethereum :fire:
Apache License 2.0
622 stars 85 forks source link

Lerna build (WIP PR) #113

Closed mul1sh closed 5 years ago

mul1sh commented 5 years ago

In this PR i've started splitting out the plugins, so next i'll add the package.json files for each of the seperate pacakages/plugins as recommended by lerna

Fixes #107

raulk commented 5 years ago

@mul1sh slight change in naming, this should be the directory structure:

packages
  |___ base
  |___ core-plugin
  |___ erc20-plugin
  |___ ens-plugin
  |___ erc721-plugin
  |___ ...

In the package.json, the package names should be preceded with @ethql, ie. @ethql/core-plugin, @ethql/base, etc.

Please provide an exact date when this issue will be finished ;-) Thanks.

mul1sh commented 5 years ago

@raulk thanks for the feedback 🙂 will implement it like this. As for the exact date for finishing this issue, I plan to finish it by this coming Friday end of day.

mul1sh commented 5 years ago

@raulk just a question before I make another commit, what files should go into base, core and erc721-plugin?

Also I can see the ens module is still not done, so how do i address the ens-plugin part? Thanks.

raulk commented 5 years ago

@mul1sh Everything that is not a plugin should go in base. The core directory contains a plugin, and should end up in core-plugin. The erc721 plugin is not ready yet, I think you mean the erc20 plugin?

Regarding ens-plugin, @StevenJNPearce should be able to help you there!

mul1sh commented 5 years ago

@raulk awesome thanks for the clarification, let me reach out to @StevenJNPearce then and wrap up whats left

raulk commented 5 years ago

@mul1sh We haven't heard from you in the last 2 weeks. We need to make progress a bit faster, so we will be putting this bounty up for grabs on Gitcoin again. Thank you.

mul1sh commented 5 years ago

@raulk sorry for the delay, I was still waiting for the ens plugin so that i wrap everything at once. Anyway no worries I understand