search

Consensys / ethql

A GraphQL interface to Ethereum :fire:
Apache License 2.0
622 stars 85 forks source link

Add ERC20 decimal field support #115

Open wtzb opened 5 years ago

wtzb commented 5 years ago

Resolves https://github.com/ConsenSys/ethql/issues/114

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

wtzb commented 5 years ago

Something like this? :)

On Tue, 30 Oct 2018, 22:47 Raúl Kripalani <notifications@github.com wrote:

@raulk commented on this pull request.

Thanks for the contribution? Could you maybe add a trivial test here? Could be as simple enhancing the existing tests to request the new field.

https://github.com/ConsenSys/ethql/blob/master/src/__tests__/erc20/erc20.test.ts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConsenSys/ethql/pull/115#pullrequestreview-170015495, or mute the thread https://github.com/notifications/unsubscribe-auth/AK4kAIebiP9IVZOV7uEoioVzROJD2W07ks5uqMjwgaJpZM4YC6Ru .

wtzb commented 5 years ago

Awesome, thanks!

On Tue, 30 Oct 2018, 22:47 Raúl Kripalani <notifications@github.com wrote:

@raulk commented on this pull request.

Thanks for the contribution? Could you maybe add a trivial test here? Could be as simple enhancing the existing tests to request the new field.

https://github.com/ConsenSys/ethql/blob/master/src/__tests__/erc20/erc20.test.ts

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ConsenSys/ethql/pull/115#pullrequestreview-170015495, or mute the thread https://github.com/notifications/unsubscribe-auth/AK4kAIebiP9IVZOV7uEoioVzROJD2W07ks5uqMjwgaJpZM4YC6Ru .