Consensys / ethql

A GraphQL interface to Ethereum :fire:
Apache License 2.0
622 stars 85 forks source link

lerna build #117

Closed evgeniuz closed 5 years ago

evgeniuz commented 5 years ago

Fixes #107

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

evgeniuz commented 5 years ago

Added very rough lerna build, still lots to do, but packages are split and building. Instructions are:

yarn install
lerna bootstrap
lerna run build:ts
node package/ethql/dist/index.js

Things still to do (non-complete list):

evgeniuz commented 5 years ago

Implemented lerna build in the best way possible (I hope :smiley:):

This combination allows running tests or dev/debug build in watch mode for easier development and is producing loosely coupled dist folders for distribution.

Instruction:

yarn install
lerna bootstrap
...
# it's not required to build before running dev or test
yarn build:ts
yarn dev
yarn test
etc.

Things I still plan to do:

Except for these things it's ready for some review (just to confirm that approach taken is good one).

evgeniuz commented 5 years ago

Fixed docker build, but not sure what's with circleCI.

evgeniuz commented 5 years ago

Technically everything should be complete, but CircleCI tests are timing out for some reason (work locally and don't take too much time). Cannot troubleshoot this as output is truncated.

evgeniuz commented 5 years ago

Cause for failure was that it was requesting too many workers and correspondingly allocating too much memory. Fixed by limiting workers to 2.

raulk commented 5 years ago

@evgeniuz thanks for the submission! I fixed the jest configuration to honor the worker limitation (not sure where this came from), and updated all versions. Could you please integrate these changes on your branch?

evgeniuz commented 5 years ago

@raulk Rebased on top of recent master changes.

evgeniuz commented 5 years ago

Are there any changes I need to implement here?

raulk commented 5 years ago

I pushed a commit a few days ago performing some further refactor, but didn't have time to comment on it. Here it goes:

raulk commented 5 years ago

Just pushed a few more commits to rationalise the build commands; hopefully it'll now pass on CI. I also fixed the Dockerfile.