Closed evgeniuz closed 5 years ago
Added very rough lerna build, still lots to do, but packages are split and building. Instructions are:
yarn install
lerna bootstrap
lerna run build:ts
node package/ethql/dist/index.js
Things still to do (non-complete list):
Implemented lerna build in the best way possible (I hope :smiley:):
nodemon
with tsc-watch
, as it's much simpler wrapper around tsc
and more suitable to work in build mode).tsconfig.json
which is not used for actual build, but used for jest. This allows to run one instance of jest to execute all tests across packages (including watch mode and coverage mode).This combination allows running tests or dev/debug build in watch mode for easier development and is producing loosely coupled dist
folders for distribution.
Instruction:
yarn install
lerna bootstrap
...
# it's not required to build before running dev or test
yarn build:ts
yarn dev
yarn test
etc.
Things I still plan to do:
Except for these things it's ready for some review (just to confirm that approach taken is good one).
Fixed docker build, but not sure what's with circleCI.
Technically everything should be complete, but CircleCI tests are timing out for some reason (work locally and don't take too much time). Cannot troubleshoot this as output is truncated.
Cause for failure was that it was requesting too many workers and correspondingly allocating too much memory. Fixed by limiting workers to 2.
@evgeniuz thanks for the submission! I fixed the jest configuration to honor the worker limitation (not sure where this came from), and updated all versions. Could you please integrate these changes on your branch?
@raulk Rebased on top of recent master changes.
Are there any changes I need to implement here?
I pushed a commit a few days ago performing some further refactor, but didn't have time to comment on it. Here it goes:
main
and typings
fields in package.json
files, and added index.ts
files where they were missing, making importing more idiomatic. Just pushed a few more commits to rationalise the build commands; hopefully it'll now pass on CI. I also fixed the Dockerfile.
Fixes #107