Issue 118: Topic filter in Logs

Consensys / ethql

A GraphQL interface to Ethereum :fire:

Apache License 2.0

622 stars 85 forks source link

Issue 118: Topic filter in Logs #120

Closed kshinn closed 5 years ago

kshinn commented 5 years ago

As described in #18 when submitting queries that have the log(filter: {topics: []}) filter engaged, all logs get returned no matter what is in the topic filter. I found that the topic argument was not getting passed into getPastLogs and in the case of the log resolver specifically, we are using a the getTransactionReceipt call which does not provide a topic filter.

This PR attempts to pass the filter through the various places where logs are getting attached to the result set.

CLAassistant commented 5 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: raulk
:white_check_mark: StevenJNPearce
:x: Kris Shinn

Kris Shinn seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

kshinn commented 5 years ago

Hmm, looking at the PR, there are a number of changes that were not intended to go onto master... I have been looking at other branches that may have gotten twisted up here. I may need to review and revise this.

kshinn commented 5 years ago

Closing PR for a cleaner branch.