Consensys / gnark-crypto

gnark-crypto provides elliptic curve and pairing-based cryptography on BN, BLS12, BLS24 and BW6 curves. It also provides various algorithms (algebra, crypto) of particular interest to zero knowledge proof systems.

Apache License 2.0

495 stars 160 forks source link

refactor: remove E3 Conjugate from BW6 #514

Closed yelhousni closed 3 months ago

yelhousni commented 3 months ago

Description

Conjugate in Fp3 for BW6-761, BW6-756 and BW6-633 are incorrect but they are not used anywhere. This PR removes the corresponding code.

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How has this been tested?

Conjugate tests are removed too.

How has this been benchmarked?

N/A

Checklist:

[x] I have performed a self-review of my code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] I have added tests that prove my fix is effective or that my feature works
[x] I did not modify files generated from templates
[x] golangci-lint does not output errors locally
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules