search

Consensys / gnark

gnark is a fast zk-SNARK library that offers a high-level API to design circuits. The library is open source and developed under the Apache 2.0 license
https://hackmd.io/@gnark
Apache License 2.0
1.41k stars 361 forks source link

bug lookup2 in plonk #254

Closed yelhousni closed 2 years ago

yelhousni commented 2 years ago 
--- FAIL: TestScalarMulFixed (0.44s)
    --- PASS: TestScalarMulFixed/bn254/groth16 (0.04s)
    --- FAIL: TestScalarMulFixed/bn254/plonk (0.03s)
    --- PASS: TestScalarMulFixed/bls12_377/groth16 (0.04s)
    --- FAIL: TestScalarMulFixed/bls12_377/plonk (0.03s)
    --- PASS: TestScalarMulFixed/bls12_381/groth16 (0.05s)
    --- FAIL: TestScalarMulFixed/bls12_381/plonk (0.04s)
    --- PASS: TestScalarMulFixed/bw6_761/groth16 (0.08s)
    --- FAIL: TestScalarMulFixed/bw6_761/plonk (0.05s)
    --- PASS: TestScalarMulFixed/bls24_315/groth16 (0.06s)
    --- FAIL: TestScalarMulFixed/bls24_315/plonk (0.04s)
yelhousni commented 2 years ago

There was no bug in Lookup2 in plonk. The bug was related to a wrong op in sparse_r1cs constraint system (fixed in fd3ce5814f2781e4386ba0dacccb7470e45f15fb by @ThomasPiellard ). Closing this issue.