Build libblst with GCC for consistency

Consensys / jblst

MIT License

8 stars 12 forks source link

Build libblst with GCC for consistency #24

Closed ajsutton closed 2 years ago

ajsutton commented 2 years ago

Previously it was trying to build it with Visual C compiler but run.me will wind up rebuilding with gcc. We could have potentially wound up with the portable flag being lost.

Pretty sure Visual C compiler isn't on the PATH for these windows boxes anyway so suspect the original build.bat call just wasn't doing anything.

ajsutton commented 2 years ago

LGTM, mostly, but not sure about the whole backslash situation with sh...

sh is taking a file path so since we're in powershell when we specify the command we use backslashes, then once sh is actually running it uses forward slashes. It's all kinds of fun.