Consensys / linea-tracer

Part of the Linea stack responsible for extracting data from the execution of an EVM client in order to construct large matrices called execution traces.
https://linea.build
Other
34 stars 22 forks source link

Reference tests may contain more than 200 (or even 256) blocks #1381

Open OlivierBBB opened 3 weeks ago

OlivierBBB commented 3 weeks ago

As a consequence certain reference tests blow up in the trace production stage

image

I am unable to run the ./gradlew hub task and rebuild the relevant Trace.java files (in particular blockdata/Trace.java) but setting the maximal number of blocks accepted by blockdata to 1024 in

  public Trace relBlock(final long b) {
    // ...
    if (b >= 1024L) {
      throw new IllegalArgumentException("relBlock has invalid value (" + b + ")");
    }
    // ...
  }

and similarly for public Trace relTxNumMax(final long b) { ... } We can make BlockchainReferenceTest_627.java pass.

letypequividelespoubelles commented 3 weeks ago

Hum ... Maybe we should disable those tests ? It's quite annoying to have to create wider columns just to make reference test passes ?

OlivierBBB commented 3 weeks ago

I don't mind making the columns wider tbh. It's a few columns in a tiny module.