search

Consensys / linea-tracer

Part of the Linea stack responsible for extracting data from the execution of an EVM client in order to construct large matrices called execution traces.
https://linea.build
Other
35 stars 26 forks source link

Data that needs to be popped #1499

Open OlivierBBB opened 1 week ago

OlivierBBB commented 1 week ago

Here are some data we follow throughout a conflation that we currently don't pop with popped transactions, but which we should just so as to be clean.

DeploymentInfo

To some extent this doesn't matter now since blocks are first sequenced (and for sequencing this popping doesn't matter) and there may always be a first round before trace production. But logically this is an oversight. And would come across as such to anyone reviewing the code. Plus this would be a place where we could add unit tests for the deployment numbers and statuses: pop a transaction that performs some deployment, redeploy in the next transaction.

letypequividelespoubelles commented 1 week ago

we could (should ?) pop the endBlockDefers and endConflationDefers