Consensys / linea-tracer

Part of the Linea stack responsible for extracting data from the execution of an EVM client in order to construct large matrices called execution traces.
https://linea.build
Other
35 stars 27 forks source link

fix: package definition for generated Trace.java files #727

Open lorenzogentile404 opened 6 months ago

lorenzogentile404 commented 6 months ago

When generating the Trace.java file for shfreftable we get as a package definition package net.consensys.linea.zktracer.module.ShfRt; while I expected packagenet.consensys.linea.zktracer.module.tables.shf;. Could this be an issue related to traces-files.gradle? Currently we have:

tasks.register('shfreftable', TraceFilesTask) {
    group "Trace files generation"
    dependsOn corsetExists

    moduleDir = "tables/shf"
    module = "ShfRt"
    files = ["reftables/shf_reftable.lisp"]
}

Double check if we have the same problem somewhere else.

DavePearce commented 4 days ago

FYI: This has been fixed now I believe in corset.